+- hashcat Forum (https://hashcat.net/forum)
+-- Forum: Support (https://hashcat.net/forum/forum-3.html)
+--- Forum: hashcat-utils, maskprocessor, statsprocessor, md5stress, wikistrip (https://hashcat.net/forum/forum-28.html)
+--- Thread: defect in outfile_write method. (/thread-6408.html)
defect in outfile_write method. - hsc - 03-20-2017
When using --outfile-format=11, hashcat is suppose to include the guess number as the last item. However, this was the output:
a2593e6a5ae8ba54b95ff7b182d738a8:jblaze:
Looking at outfile_write, I tracked down the problem. Variable 'tmp_len' needs to be increased in size to accommodate the crackpos text. Here is my rudimentary fix on line 439:
435: if (outfile_ctx->outfile_format & OUTFILE_FMT_CRACKPOS)
436: {
437: sprintf (tmp_buf + tmp_len, "%" PRIu64, crackpos);
438: }
439: tmp_len += 20; // Need to move end of the buffer to include crackpos.
440: tmp_buf[tmp_len] = 0;
After adding line 439, the output is now:
a2593e6a5ae8ba54b95ff7b182d738a8:jblaze:9612916440
I'm using version 3.40 of hashcat. Please let me know if this is the right place to post such things.
RE: defect in outfile_write method. - Xanadrel - 03-20-2017
(03-20-2017, 02:01 AM)hsc Wrote: I'm using version 3.40 of hashcat. Please let me know if this is the right place to post such things.
Good contributions are welcome, but should go on github, either:
- create an issue: https://github.com/hashcat/hashcat/issues
- fix the issue, and create a PR: https://github.com/hashcat/hashcat/pulls
RE: defect in outfile_write method. - hsc - 03-20-2017
(03-20-2017, 02:30 AM)Xanadrel Wrote:(03-20-2017, 02:01 AM)hsc Wrote: I'm using version 3.40 of hashcat. Please let me know if this is the right place to post such things.
Good contributions are welcome, but should go on github, either:
- create an issue: https://github.com/hashcat/hashcat/issues
- fix the issue, and create a PR: https://github.com/hashcat/hashcat/pulls
Submitted into github. Issue #1194. PR #1195.