10-22-2021, 04:17 PM
nice find, it really seems so that this commit https://github.com/hashcat/hashcat/commit/0a60805 did change more than just the way we do the "utf16 encoding". The buffer sizes were changed; and you are right it seems that buffers do overflow with the new code. We should ask atom/jsteube if it's enough to just keep the old/correct buffer size also for the updated utf16 encoding.
The original code seems to not have this problem (i.e. any version of the -m 22400 hash module before the urf16 encoding change).
Please open a new issue on github https://github.com/hashcat/hashcat/issues and mention these details (your observation about the buffer overflow and which commit seem to have broken it). Thx
The original code seems to not have this problem (i.e. any version of the -m 22400 hash module before the urf16 encoding change).
Please open a new issue on github https://github.com/hashcat/hashcat/issues and mention these details (your observation about the buffer overflow and which commit seem to have broken it). Thx